Improve abi types in wasmv1 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
* Unify current_thread and current_period * Removed Non 'For' ABIs * Updated numbers in ABI Results * Removed logs / trace / prints * Forgot to remove some duplicated definitions
see massalabs/massa-sc-runtime#246 (comment) for details GenerateEvent takes bytes Use the optional keyword when appropriate Use StringValue for optional string Signed-off-by: Jean-François Morcillo <[email protected]>
… none Signed-off-by: Jean-François Morcillo <[email protected]>
…_message Unsafe random and async message
|
We have to merge soon, so I'm opening the PR to sync with the API guys and prevent conflict as much as possible on both sides. |
… 0 form none Signed-off-by: Jean-François Morcillo <[email protected]>
|
On the abi side we estimate that we won't have many more changes for the moment. |
damip
reviewed
Jul 4, 2023
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
get origin op id
Signed-off-by: Jean-François Morcillo <[email protected]>
…edRequest, DateNowRequest, ProcessExitRequest Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Evm update v2
bilboquet
commented
Jul 25, 2023
| @@ -175,8 +175,11 @@ message RespResult { | |||
| SubNativeAmountResult sub_native_amount_result = 55; | |||
| TransferCoinsResult transfer_coins_result = 56; | |||
| UnsafeRandomResult unsafe_random_result = 57; | |||
| VerifyEvmSigResult verify_evm_sig_result = 58; | |||
| EvmVerifySigResult evm_verify_sig_result = 58; | |||
There was a problem hiding this comment.
I can't believe it!
It's not sorted!!!
bilboquet
commented
Jul 25, 2023
| VerifySigResult verify_sig_result = 59; | ||
| EvmGetAddressFromPubkeyResult evm_get_address_from_pubkey_result = 60; | ||
| EvmGetPubkeyFromSignatureResult evm_get_pubkey_from_signature_result = 61; | ||
| IsAddressEoaResult is_address_eoa_result = 62; |
There was a problem hiding this comment.
what's the meaning of this one?
Eitu33
approved these changes
Jul 26, 2023
Leo-Besancon
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
issue 246 from massa-sc-runtime