-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve abi types in wasmv1 #27
Conversation
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
* Unify current_thread and current_period * Removed Non 'For' ABIs * Updated numbers in ABI Results * Removed logs / trace / prints * Forgot to remove some duplicated definitions
see massalabs/massa-sc-runtime#246 (comment) for details GenerateEvent takes bytes Use the optional keyword when appropriate Use StringValue for optional string Signed-off-by: Jean-François Morcillo <[email protected]>
… none Signed-off-by: Jean-François Morcillo <[email protected]>
…_message Unsafe random and async message
We have to merge soon, so I'm opening the PR to sync with the API guys and prevent conflict as much as possible on both sides. |
… 0 form none Signed-off-by: Jean-François Morcillo <[email protected]>
On the abi side we estimate that we won't have many more changes for the moment. |
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
get origin op id
Signed-off-by: Jean-François Morcillo <[email protected]>
…edRequest, DateNowRequest, ProcessExitRequest Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Signed-off-by: Jean-François Morcillo <[email protected]>
Evm update v2
@@ -175,8 +175,11 @@ message RespResult { | |||
SubNativeAmountResult sub_native_amount_result = 55; | |||
TransferCoinsResult transfer_coins_result = 56; | |||
UnsafeRandomResult unsafe_random_result = 57; | |||
VerifyEvmSigResult verify_evm_sig_result = 58; | |||
EvmVerifySigResult evm_verify_sig_result = 58; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't believe it!
It's not sorted!!!
VerifySigResult verify_sig_result = 59; | ||
EvmGetAddressFromPubkeyResult evm_get_address_from_pubkey_result = 60; | ||
EvmGetPubkeyFromSignatureResult evm_get_pubkey_from_signature_result = 61; | ||
IsAddressEoaResult is_address_eoa_result = 62; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the meaning of this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved despite the lack of sorting..
Related to
issue 246 from massa-sc-runtime